RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 05:37:43 +00:00
Code Issues Activity Actions

LibWeb: Allow window.setTimeout() with no interval

Browse source 
If no interval is specified, it will be treated as 0 and the callback
function will be called on the next event loop iteration.
This commit is contained in:
Andreas Kling 2020-04-05 19:04:00 +02:00
parent 003741db1c
commit 6e5c9970bf
1 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Libraries/LibWeb/Bindings/WindowObject.cpp
View file

@ -104,14 +104,19 @@ JS::Value WindowObject::set_timeout(JS::Interpreter& interpreter)
if (!impl) if (!impl)
return {}; return {};
auto& arguments = interpreter.call_frame().arguments; auto& arguments = interpreter.call_frame().arguments;
if (arguments.size() < 2) if (arguments.size() < 1)
return {}; return {};
auto* callback_object = arguments[0].to_object(interpreter.heap()); auto* callback_object = arguments[0].to_object(interpreter.heap());
if (!callback_object) if (!callback_object)
return {}; return {};
if (!callback_object->is_function()) if (!callback_object->is_function())
return interpreter.throw_exception<JS::Error>("TypeError", "Not a function"); return interpreter.throw_exception<JS::Error>("TypeError", "Not a function");
impl->set_timeout(*static_cast<JS::Function*>(callback_object), arguments[1].to_i32());
i32 interval = 0;
if (interpreter.argument_count() >= 2)
interval = arguments[1].to_i32();
impl->set_timeout(*static_cast<JS::Function*>(callback_object), interval);
return {}; return {};
} }