RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 19:14:58 +00:00
Code Issues Activity Actions

Kernel: Resize Ext2FSInode when writing directory contents (#6897)

Browse source 
Ext2 directory contents are stored in a linked list of ext2_dir_entry
structs. There is no sentinel value to determine where the list ends.
Instead the list fills the entirety of the allocated space for the
inode.

Previously the inode was not correctly resized when it became smaller.
This resulted in stale data being interpreted as part of the linked list
of directory entries.
This commit is contained in:
Mart G 2021-05-06 17:53:59 +02:00 • committed by GitHub
parent f1791eca13
commit 6e641fadfa
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Kernel/FileSystem/Ext2FileSystem.cpp
View file

@ -1112,6 +1112,9 @@ KResult Ext2FSInode::write_directory(const Vector<Ext2FSDirectoryEntry>& entries
stream.fill_to_end(0);
if (auto result = resize(stream.size()); result.is_error())
return result;
auto buffer = UserOrKernelBuffer::for_kernel_buffer(stream.data());
auto result = write_bytes(0, stream.size(), buffer, nullptr);
if (result.is_error())