RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-15 16:14:58 +00:00
Code Issues Activity Actions

LibJS: Rename ZonedDateTime's MatchBehavior enum members to match spec

Browse source
This commit is contained in:
Linus Groh 2021-11-10 21:27:25 +00:00
parent f86ee71f65
commit 6ef1a2793f
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibJS/Runtime/Temporal/ZonedDateTime.cpp
View file

@ -93,7 +93,7 @@ ThrowCompletionOr<BigInt const*> interpret_iso_date_time_offset(GlobalObject& gl
} }
// c. If matchBehaviour is match minutes, then // c. If matchBehaviour is match minutes, then
if (match_behavior == MatchBehavior::MatchMinutes) { if (match_behavior == MatchBehavior::Minutes) {
// i. Let roundedCandidateNanoseconds be ! RoundNumberToIncrement(candidateNanoseconds, 60 × 10^9, "halfExpand"). // i. Let roundedCandidateNanoseconds be ! RoundNumberToIncrement(candidateNanoseconds, 60 × 10^9, "halfExpand").
auto rounded_candidate_nanoseconds = round_number_to_increment(candidate_nanoseconds, 60000000000, "halfExpand"sv); auto rounded_candidate_nanoseconds = round_number_to_increment(candidate_nanoseconds, 60000000000, "halfExpand"sv);
@ -129,7 +129,7 @@ ThrowCompletionOr<ZonedDateTime*> to_temporal_zoned_date_time(GlobalObject& glob
auto offset_behavior = OffsetBehavior::Option; auto offset_behavior = OffsetBehavior::Option;
// 3. Let matchBehaviour be match exactly. // 3. Let matchBehaviour be match exactly.
auto match_behavior = MatchBehavior::MatchExactly; auto match_behavior = MatchBehavior::Exactly;
Object* calendar = nullptr; Object* calendar = nullptr;
Object* time_zone = nullptr; Object* time_zone = nullptr;
@ -222,7 +222,7 @@ ThrowCompletionOr<ZonedDateTime*> to_temporal_zoned_date_time(GlobalObject& glob
calendar = TRY(to_temporal_calendar_with_iso_default(global_object, js_string(vm, parsed_result.date_time.calendar.value()))); calendar = TRY(to_temporal_calendar_with_iso_default(global_object, js_string(vm, parsed_result.date_time.calendar.value())));
// j. Set matchBehaviour to match minutes. // j. Set matchBehaviour to match minutes.
match_behavior = MatchBehavior::MatchMinutes; match_behavior = MatchBehavior::Minutes;
// See NOTE above about why this is done. // See NOTE above about why this is done.
result = move(parsed_result.date_time); result = move(parsed_result.date_time);

4
Userland/Libraries/LibJS/Runtime/Temporal/ZonedDateTime.h
View file

@ -47,8 +47,8 @@ enum class OffsetBehavior {
}; };
enum class MatchBehavior { enum class MatchBehavior {
MatchExactly, Exactly,
MatchMinutes, Minutes,
}; };
ThrowCompletionOr<BigInt const*> interpret_iso_date_time_offset(GlobalObject&, i32 year, u8 month, u8 day, u8 hour, u8 minute, u8 second, u16 millisecond, u16 microsecond, u16 nanosecond, OffsetBehavior offset_behavior, double offset_nanoseconds, Value time_zone, StringView disambiguation, StringView offset_option, MatchBehavior match_behavior); ThrowCompletionOr<BigInt const*> interpret_iso_date_time_offset(GlobalObject&, i32 year, u8 month, u8 day, u8 hour, u8 minute, u8 second, u16 millisecond, u16 microsecond, u16 nanosecond, OffsetBehavior offset_behavior, double offset_nanoseconds, Value time_zone, StringView disambiguation, StringView offset_option, MatchBehavior match_behavior);