RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:47:44 +00:00
Code Issues Activity Actions

LibWeb: Fix null dereference on SVG element with bogus fill URL

Browse source 
Fixes a crash seen on YouTube channel pages.
This commit is contained in:
Andreas Kling 2023-05-19 15:14:34 +02:00
parent 411b28fc59
commit 6f204f8c32
3 changed files with 15 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Tests/LibWeb/Layout/expected/svg/svg-fill-with-bogus-url.txt Normal file
View file

@ -0,0 +1,7 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x37.835937 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x21.835937 children: inline
line 0 width: 0, height: 21.835937, bottom: 21.835937, baseline: 100
frag 0 from SVGSVGBox start: 0, length: 0, rect: [8,8 0x0]
SVGSVGBox <svg> at (8,8) content-size 0x0 [SVG] children: not-inline
SVGGeometryBox <rect> at (8,8) content-size 100x100 children: not-inline

3
Tests/LibWeb/Layout/input/svg/svg-fill-with-bogus-url.html Normal file
View file

@ -0,0 +1,3 @@
<!doctype html><style>
* { font: 20px SerenitySans; }
</style><svg viewBox="0 0 100 100"><rect x=0 y=0 width=100 height=100 fill="url(#bogus)"></svg>

10
Userland/Libraries/LibWeb/SVG/SVGGraphicsElement.cpp
View file

@ -51,11 +51,11 @@ Optional<Gfx::PaintStyle const&> SVGGraphicsElement::fill_paint_style(SVGPaintCo
if (!fill.has_value() || !fill->is_url()) if (!fill.has_value() || !fill->is_url())
return {}; return {};
auto& url = fill->as_url(); auto& url = fill->as_url();
auto maybe_gradient = document().get_element_by_id(url.fragment()); auto gradient = document().get_element_by_id(url.fragment());
if (is<SVG::SVGGradientElement>(*maybe_gradient)) { if (!gradient)
auto& gradient = verify_cast<SVG::SVGGradientElement>(*maybe_gradient); return {};
return gradient.to_gfx_paint_style(paint_context); if (is<SVG::SVGGradientElement>(*gradient))
} return static_cast<SVG::SVGGradientElement const&>(*gradient).to_gfx_paint_style(paint_context);
return {}; return {};
} }