From 6f3e48db57790fc5cb15a7d854246d7ee4e7c802 Mon Sep 17 00:00:00 2001 From: Sam Atkins Date: Wed, 10 May 2023 17:19:08 +0100 Subject: [PATCH] LibWeb: Fill in some missing property data and bodge extra types We don't yet have generic parsing support for `` or ``, so listing them here confuses the new StyleValue parsing code I'm working on. For now, let's skip `` since it's only used in one pkace which manually parses it, and list the parts of `` instead which are taken from here: https://www.w3.org/TR/SVG2/painting.html#SpecifyingPaint --- Userland/Libraries/LibWeb/CSS/Properties.json | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/Userland/Libraries/LibWeb/CSS/Properties.json b/Userland/Libraries/LibWeb/CSS/Properties.json index 20e56e3e28..485679343a 100644 --- a/Userland/Libraries/LibWeb/CSS/Properties.json +++ b/Userland/Libraries/LibWeb/CSS/Properties.json @@ -42,9 +42,7 @@ "affects-stacking-context": true, "inherited": false, "initial": "none", - "valid-types": [ - "filter-value-list" - ], + "__comment": "FIXME: List `filter-value-list` as a valid-type once it's generically supported.", "valid-identifiers": [ "none" ] @@ -392,6 +390,9 @@ "border-spacing": { "inherited": true, "initial": "0", + "valid-types": [ + "length" + ], "quirks": [ "unitless-length" ] @@ -413,6 +414,9 @@ "affects-layout": false, "initial": "currentcolor", "inherited": false, + "valid-types": [ + "color" + ], "quirks": [ "hashless-hex-color" ] @@ -622,8 +626,10 @@ "affects-layout": false, "inherited": true, "initial": "black", + "__comment": "FIXME: Use `paint` as the type, once we have a PaintStyleValue and generic parsing for it.", "valid-types": [ - "paint" + "color", + "url" ], "valid-identifiers": [ "none"