RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 22:07:36 +00:00
Code Issues Activity Actions

LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated

Browse source 
This is a monster patch that turns all EventTargets into GC-allocated
PlatformObjects. Their C++ wrapper classes are removed, and the LibJS
garbage collector is now responsible for their lifetimes.

There's a fair amount of hacks and band-aids in this patch, and we'll
have a lot of cleanup to do after this.
This commit is contained in:
Andreas Kling 2022-08-28 13:42:07 +02:00
parent bb547ce1c4
commit 6f433c8656
445 changed files with 4797 additions and 4268 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibWeb/DOM/Attribute.h
View file

@ -15,10 +15,10 @@ namespace Web::DOM {
// https://dom.spec.whatwg.org/#attr
class Attribute final : public Node {
public:
using WrapperType = Bindings::AttributeWrapper;
WEB_PLATFORM_OBJECT(Attribute, Node);
static NonnullRefPtr<Attribute> create(Document&, FlyString local_name, String value, Element const* = nullptr);
public:
static JS::NonnullGCPtr<Attribute> create(Document&, FlyString local_name, String value, Element const* = nullptr);
virtual ~Attribute() override = default;
@ -44,12 +44,16 @@ public:
private:
Attribute(Document&, FlyString local_name, String value, Element const*);
virtual void visit_edges(Cell::Visitor&) override;
QualifiedName m_qualified_name;
String m_value;
WeakPtr<Element> m_owner_element;
JS::GCPtr<Element> m_owner_element;
};
template<>
inline bool Node::fast_is<Attribute>() const { return is_attribute(); }
}
WRAPPER_HACK(Attribute, Web::DOM)