RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 05:38:11 +00:00
Code Issues Activity Actions

LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated

Browse source 
This is a monster patch that turns all EventTargets into GC-allocated
PlatformObjects. Their C++ wrapper classes are removed, and the LibJS
garbage collector is now responsible for their lifetimes.

There's a fair amount of hacks and band-aids in this patch, and we'll
have a lot of cleanup to do after this.
This commit is contained in:
Andreas Kling 2022-08-28 13:42:07 +02:00
parent bb547ce1c4
commit 6f433c8656
445 changed files with 4797 additions and 4268 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWeb/DOM/HTMLCollection.cpp
View file

@ -13,19 +13,19 @@
namespace Web::DOM {
HTMLCollection::HTMLCollection(ParentNode& root, Function<bool(Element const&)> filter)
: m_root(root)
: m_root(JS::make_handle(root))
, m_filter(move(filter))
{
}
HTMLCollection::~HTMLCollection() = default;
Vector<NonnullRefPtr<Element>> HTMLCollection::collect_matching_elements() const
JS::MarkedVector<Element*> HTMLCollection::collect_matching_elements() const
{
Vector<NonnullRefPtr<Element>> elements;
JS::MarkedVector<Element*> elements(m_root->heap());
m_root->for_each_in_inclusive_subtree_of_type<Element>([&](auto& element) {
if (m_filter(element))
elements.append(element);
elements.append(const_cast<Element*>(&element));
return IterationDecision::Continue;
});
return elements;