RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:17:45 +00:00
Code Issues Activity Actions

LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated

Browse source 
This is a monster patch that turns all EventTargets into GC-allocated
PlatformObjects. Their C++ wrapper classes are removed, and the LibJS
garbage collector is now responsible for their lifetimes.

There's a fair amount of hacks and band-aids in this patch, and we'll
have a lot of cleanup to do after this.
This commit is contained in:
Andreas Kling 2022-08-28 13:42:07 +02:00
parent bb547ce1c4
commit 6f433c8656
445 changed files with 4797 additions and 4268 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibWeb/DOM/LiveNodeList.cpp
View file

@ -10,17 +10,17 @@
namespace Web::DOM {
LiveNodeList::LiveNodeList(Node& root, Function<bool(Node const&)> filter)
: m_root(root)
: m_root(JS::make_handle(root))
, m_filter(move(filter))
{
}
NonnullRefPtrVector<Node> LiveNodeList::collection() const
JS::MarkedVector<Node*> LiveNodeList::collection() const
{
NonnullRefPtrVector<Node> nodes;
JS::MarkedVector<Node*> nodes(m_root->heap());
m_root->for_each_in_inclusive_subtree([&](auto& node) {
if (m_filter(node))
nodes.append(node);
nodes.append(const_cast<Node*>(&node));
return IterationDecision::Continue;
});
@ -40,7 +40,7 @@ Node const* LiveNodeList::item(u32 index) const
auto nodes = collection();
if (index >= nodes.size())
return nullptr;
return &nodes[index];
return nodes[index];
}
// https://dom.spec.whatwg.org/#ref-for-dfn-supported-property-indices