RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:47:45 +00:00
Code Issues Activity Actions

LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated

Browse source 
This is a monster patch that turns all EventTargets into GC-allocated
PlatformObjects. Their C++ wrapper classes are removed, and the LibJS
garbage collector is now responsible for their lifetimes.

There's a fair amount of hacks and band-aids in this patch, and we'll
have a lot of cleanup to do after this.
This commit is contained in:
Andreas Kling 2022-08-28 13:42:07 +02:00
parent bb547ce1c4
commit 6f433c8656
445 changed files with 4797 additions and 4268 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Userland/Libraries/LibWeb/DOM/MutationRecord.cpp
View file

@ -14,11 +14,11 @@ class MutationRecordImpl final : public MutationRecord {
public:
MutationRecordImpl(FlyString const& type, Node& target, NodeList& added_nodes, NodeList& removed_nodes, Node* previous_sibling, Node* next_sibling, String const& attribute_name, String const& attribute_namespace, String const& old_value)
: m_type(type)
, m_target(target)
, m_target(JS::make_handle(target))
, m_added_nodes(added_nodes)
, m_removed_nodes(removed_nodes)
, m_previous_sibling(previous_sibling)
, m_next_sibling(next_sibling)
, m_previous_sibling(JS::make_handle(previous_sibling))
, m_next_sibling(JS::make_handle(next_sibling))
, m_attribute_name(attribute_name)
, m_attribute_namespace(attribute_namespace)
, m_old_value(old_value)
@ -28,22 +28,22 @@ public:
virtual ~MutationRecordImpl() override = default;
virtual FlyString const& type() const override { return m_type; }
virtual Node const* target() const override { return m_target; }
virtual Node const* target() const override { return m_target.ptr(); }
virtual NodeList const* added_nodes() const override { return m_added_nodes; }
virtual NodeList const* removed_nodes() const override { return m_removed_nodes; }
virtual Node const* previous_sibling() const override { return m_previous_sibling; }
virtual Node const* next_sibling() const override { return m_next_sibling; }
virtual Node const* previous_sibling() const override { return m_previous_sibling.ptr(); }
virtual Node const* next_sibling() const override { return m_next_sibling.ptr(); }
virtual String const& attribute_name() const override { return m_attribute_name; }
virtual String const& attribute_namespace() const override { return m_attribute_namespace; }
virtual String const& old_value() const override { return m_old_value; }
private:
FlyString m_type;
NonnullRefPtr<Node> m_target;
JS::Handle<Node> m_target;
NonnullRefPtr<NodeList> m_added_nodes;
NonnullRefPtr<NodeList> m_removed_nodes;
RefPtr<Node> m_previous_sibling;
RefPtr<Node> m_next_sibling;
JS::Handle<Node> m_previous_sibling;
JS::Handle<Node> m_next_sibling;
String m_attribute_name;
String m_attribute_namespace;
String m_old_value;