RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 21:47:46 +00:00
Code Issues Activity Actions

LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated

Browse source 
This is a monster patch that turns all EventTargets into GC-allocated
PlatformObjects. Their C++ wrapper classes are removed, and the LibJS
garbage collector is now responsible for their lifetimes.

There's a fair amount of hacks and band-aids in this patch, and we'll
have a lot of cleanup to do after this.
This commit is contained in:
Andreas Kling 2022-08-28 13:42:07 +02:00
parent bb547ce1c4
commit 6f433c8656
445 changed files with 4797 additions and 4268 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibWeb/DOM/Position.h
View file

@ -18,10 +18,10 @@ public:
Position() = default;
Position(Node&, unsigned offset);
bool is_valid() const { return m_node; }
bool is_valid() const { return m_node.ptr(); }
Node* node() { return m_node; }
Node const* node() const { return m_node; }
Node* node() { return m_node.cell(); }
Node const* node() const { return m_node.cell(); }
unsigned offset() const { return m_offset; }
bool offset_is_at_end_of_node() const;
@ -31,7 +31,7 @@ public:
bool operator==(Position const& other) const
{
return m_node == other.m_node && m_offset == other.m_offset;
return m_node.ptr() == other.m_node.ptr() && m_offset == other.m_offset;
}
bool operator!=(Position const& other) const
@ -42,7 +42,7 @@ public:
String to_string() const;
private:
RefPtr<Node> m_node;
JS::Handle<Node> m_node;
unsigned m_offset { 0 };
};