RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 18:18:12 +00:00
Code Issues Activity Actions

LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated

Browse source 
This is a monster patch that turns all EventTargets into GC-allocated
PlatformObjects. Their C++ wrapper classes are removed, and the LibJS
garbage collector is now responsible for their lifetimes.

There's a fair amount of hacks and band-aids in this patch, and we'll
have a lot of cleanup to do after this.
This commit is contained in:
Andreas Kling 2022-08-28 13:42:07 +02:00
parent bb547ce1c4
commit 6f433c8656
445 changed files with 4797 additions and 4268 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibWeb/DOM/StaticNodeList.cpp
View file

@ -8,7 +8,12 @@
namespace Web::DOM {
StaticNodeList::StaticNodeList(NonnullRefPtrVector<Node>&& static_nodes)
NonnullRefPtr<NodeList> StaticNodeList::create(Vector<JS::Handle<Node>> static_nodes)
{
return adopt_ref(*new StaticNodeList(move(static_nodes)));
}
StaticNodeList::StaticNodeList(Vector<JS::Handle<Node>> static_nodes)
: m_static_nodes(move(static_nodes))
{
}
@ -25,7 +30,7 @@ Node const* StaticNodeList::item(u32 index) const
// The item(index) method must return the indexth node in the collection. If there is no indexth node in the collection, then the method must return null.
if (index >= m_static_nodes.size())
return nullptr;
return &m_static_nodes[index];
return m_static_nodes[index].ptr();
}
// https://dom.spec.whatwg.org/#ref-for-dfn-supported-property-indices