RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:08:10 +00:00
Code Issues Activity Actions

LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated

Browse source 
This is a monster patch that turns all EventTargets into GC-allocated
PlatformObjects. Their C++ wrapper classes are removed, and the LibJS
garbage collector is now responsible for their lifetimes.

There's a fair amount of hacks and band-aids in this patch, and we'll
have a lot of cleanup to do after this.
This commit is contained in:
Andreas Kling 2022-08-28 13:42:07 +02:00
parent bb547ce1c4
commit 6f433c8656
445 changed files with 4797 additions and 4268 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibWeb/HTML/HTMLSelectElement.h
View file

@ -17,12 +17,10 @@ namespace Web::HTML {
class HTMLSelectElement final
: public HTMLElement
, public FormAssociatedElement {
WEB_PLATFORM_OBJECT(HTMLSelectElement, HTMLElement);
FORM_ASSOCIATED_ELEMENT(HTMLElement, HTMLSelectElement)
public:
using WrapperType = Bindings::HTMLSelectElementWrapper;
HTMLSelectElement(DOM::Document&, DOM::QualifiedName);
virtual ~HTMLSelectElement() override;
RefPtr<HTMLOptionsCollection> const& options();
@ -32,7 +30,7 @@ public:
int selected_index() const;
void set_selected_index(int);
NonnullRefPtrVector<HTMLOptionElement> list_of_options() const;
Vector<JS::Handle<HTMLOptionElement>> list_of_options() const;
// ^EventTarget
// https://html.spec.whatwg.org/multipage/interaction.html#the-tabindex-attribute:the-select-element
@ -56,7 +54,11 @@ public:
virtual bool is_labelable() const override { return true; }
private:
HTMLSelectElement(DOM::Document&, DOM::QualifiedName);
RefPtr<HTMLOptionsCollection> m_options;
};
}
WRAPPER_HACK(HTMLSelectElement, Web::HTML)