RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 08:08:12 +00:00
Code Issues Activity Actions

LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated

Browse source 
This is a monster patch that turns all EventTargets into GC-allocated
PlatformObjects. Their C++ wrapper classes are removed, and the LibJS
garbage collector is now responsible for their lifetimes.

There's a fair amount of hacks and band-aids in this patch, and we'll
have a lot of cleanup to do after this.
This commit is contained in:
Andreas Kling 2022-08-28 13:42:07 +02:00
parent bb547ce1c4
commit 6f433c8656
445 changed files with 4797 additions and 4268 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Userland/Libraries/LibWeb/HTML/HTMLStyleElement.h
View file

@ -12,10 +12,9 @@
namespace Web::HTML {
class HTMLStyleElement final : public HTMLElement {
public:
using WrapperType = Bindings::HTMLStyleElementWrapper;
WEB_PLATFORM_OBJECT(HTMLStyleElement, HTMLElement);
HTMLStyleElement(DOM::Document&, DOM::QualifiedName);
public:
virtual ~HTMLStyleElement() override;
virtual void children_changed() override;
@ -28,8 +27,14 @@ public:
CSS::CSSStyleSheet const* sheet() const;
private:
HTMLStyleElement(DOM::Document&, DOM::QualifiedName);
virtual void visit_edges(Cell::Visitor&) override;
// https://www.w3.org/TR/cssom/#associated-css-style-sheet
JS::Handle<CSS::CSSStyleSheet> m_associated_css_style_sheet;
JS::GCPtr<CSS::CSSStyleSheet> m_associated_css_style_sheet;
};
}
WRAPPER_HACK(HTMLStyleElement, Web::HTML)