RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 04:28:13 +00:00
Code Issues Activity Actions

LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated

Browse source 
This is a monster patch that turns all EventTargets into GC-allocated
PlatformObjects. Their C++ wrapper classes are removed, and the LibJS
garbage collector is now responsible for their lifetimes.

There's a fair amount of hacks and band-aids in this patch, and we'll
have a lot of cleanup to do after this.
This commit is contained in:
Andreas Kling 2022-08-28 13:42:07 +02:00
parent bb547ce1c4
commit 6f433c8656
445 changed files with 4797 additions and 4268 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/HTML/Scripting/WorkerEnvironmentSettingsObject.h
View file

@ -20,7 +20,7 @@ class WorkerEnvironmentSettingsObject final
public:
WorkerEnvironmentSettingsObject(DOM::Document& document, NonnullOwnPtr<JS::ExecutionContext> execution_context)
: EnvironmentSettingsObject(move(execution_context))
, m_document(document)
, m_document(JS::make_handle(document))
{
}
@ -37,14 +37,14 @@ public:
virtual ~WorkerEnvironmentSettingsObject() override = default;
RefPtr<DOM::Document> responsible_document() override { return m_document; }
JS::GCPtr<DOM::Document> responsible_document() override { return m_document.ptr(); }
String api_url_character_encoding() override { return m_document->encoding_or_default(); }
AK::URL api_base_url() override { return m_document->url(); }
Origin origin() override { return m_document->origin(); }
CanUseCrossOriginIsolatedAPIs cross_origin_isolated_capability() override { TODO(); }
private:
NonnullRefPtr<DOM::Document> m_document;
JS::Handle<DOM::Document> m_document;
};
}