RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 20:37:36 +00:00
Code Issues Activity Actions

LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated

Browse source 
This is a monster patch that turns all EventTargets into GC-allocated
PlatformObjects. Their C++ wrapper classes are removed, and the LibJS
garbage collector is now responsible for their lifetimes.

There's a fair amount of hacks and band-aids in this patch, and we'll
have a lot of cleanup to do after this.
This commit is contained in:
Andreas Kling 2022-08-28 13:42:07 +02:00
parent bb547ce1c4
commit 6f433c8656
445 changed files with 4797 additions and 4268 deletions
Download patch file Download diff file Expand all files Collapse all files

26
Userland/Libraries/LibWeb/HighResolutionTime/Performance.cpp
View file

@ -4,7 +4,7 @@
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibWeb/Bindings/PerformanceWrapper.h>
#include <LibWeb/Bindings/PerformancePrototype.h>
#include <LibWeb/DOM/Document.h>
#include <LibWeb/DOM/Event.h>
#include <LibWeb/DOM/EventDispatcher.h>
@ -14,34 +14,26 @@
namespace Web::HighResolutionTime {
Performance::Performance(HTML::Window& window)
: DOM::EventTarget()
: DOM::EventTarget(window.realm())
, m_window(window)
, m_timing(make<NavigationTiming::PerformanceTiming>(window))
{
set_prototype(&window.ensure_web_prototype<Bindings::PerformancePrototype>("Performance"));
m_timer.start();
}
Performance::~Performance() = default;
void Performance::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_window.ptr());
}
double Performance::time_origin() const
{
auto origin = m_timer.origin_time();
return (origin.tv_sec * 1000.0) + (origin.tv_usec / 1000.0);
}
void Performance::ref_event_target()
{
m_window.ref();
}
void Performance::unref_event_target()
{
m_window.unref();
}
JS::Object* Performance::create_wrapper(JS::Realm& realm)
{
return Bindings::wrap(realm, *this);
}
}

28
Userland/Libraries/LibWeb/HighResolutionTime/Performance.h
View file

@ -14,31 +14,29 @@
namespace Web::HighResolutionTime {
class Performance final
: public DOM::EventTarget
, public Bindings::Wrappable {
public:
using WrapperType = Bindings::PerformanceWrapper;
using AllowOwnPtr = TrueType;
class Performance final : public DOM::EventTarget {
WEB_PLATFORM_OBJECT(Performance, DOM::EventTarget);
explicit Performance(HTML::Window&);
~Performance();
public:
virtual ~Performance() override;
double now() const { return m_timer.elapsed(); }
double time_origin() const;
RefPtr<NavigationTiming::PerformanceTiming> timing() { return *m_timing; }
virtual void ref_event_target() override;
virtual void unref_event_target() override;
virtual JS::Object* create_wrapper(JS::Realm&) override;
JS::GCPtr<NavigationTiming::PerformanceTiming> timing() { return *m_timing; }
private:
HTML::Window& m_window;
explicit Performance(HTML::Window&);
virtual void visit_edges(Cell::Visitor&) override;
JS::NonnullGCPtr<HTML::Window> m_window;
Core::ElapsedTimer m_timer;
OwnPtr<NavigationTiming::PerformanceTiming> m_timing;
};
}
WRAPPER_HACK(Performance, Web::HighResolutionTime)