RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 18:27:39 +00:00
Code Issues Activity Actions

LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated

Browse source 
This is a monster patch that turns all EventTargets into GC-allocated
PlatformObjects. Their C++ wrapper classes are removed, and the LibJS
garbage collector is now responsible for their lifetimes.

There's a fair amount of hacks and band-aids in this patch, and we'll
have a lot of cleanup to do after this.
This commit is contained in:
Andreas Kling 2022-08-28 13:42:07 +02:00
parent bb547ce1c4
commit 6f433c8656
445 changed files with 4797 additions and 4268 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Userland/Libraries/LibWeb/SVG/SVGElement.h
View file

@ -12,18 +12,22 @@
namespace Web::SVG {
class SVGElement : public DOM::Element {
public:
using WrapperType = Bindings::SVGElementWrapper;
WEB_PLATFORM_OBJECT(SVGElement, DOM::Element);
public:
virtual bool requires_svg_container() const override { return true; }
HTML::DOMStringMap* dataset() { return m_dataset.cell(); }
HTML::DOMStringMap const* dataset() const { return m_dataset.cell(); }
HTML::DOMStringMap* dataset() { return m_dataset.ptr(); }
HTML::DOMStringMap const* dataset() const { return m_dataset.ptr(); }
protected:
SVGElement(DOM::Document&, DOM::QualifiedName);
JS::Handle<HTML::DOMStringMap> m_dataset;
virtual void visit_edges(Cell::Visitor&) override;
JS::NonnullGCPtr<HTML::DOMStringMap> m_dataset;
};
}
WRAPPER_HACK(SVGElement, Web::SVG)