RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 19:47:34 +00:00
Code Issues Activity Actions

LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated

Browse source 
This is a monster patch that turns all EventTargets into GC-allocated
PlatformObjects. Their C++ wrapper classes are removed, and the LibJS
garbage collector is now responsible for their lifetimes.

There's a fair amount of hacks and band-aids in this patch, and we'll
have a lot of cleanup to do after this.
This commit is contained in:
Andreas Kling 2022-08-28 13:42:07 +02:00
parent bb547ce1c4
commit 6f433c8656
445 changed files with 4797 additions and 4268 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Userland/Libraries/LibWeb/UIEvents/UIEvent.h
View file

@ -13,25 +13,23 @@
namespace Web::UIEvents {
struct UIEventInit : public DOM::EventInit {
RefPtr<HTML::Window> view { nullptr };
JS::GCPtr<HTML::Window> view;
int detail { 0 };
};
class UIEvent : public DOM::Event {
JS_OBJECT(UIEvent, DOM::Event);
WEB_PLATFORM_OBJECT(UIEvent, DOM::Event);
public:
static UIEvent* create(Bindings::WindowObject&, FlyString const& type);
static UIEvent* create_with_global_object(Bindings::WindowObject&, FlyString const& event_name, UIEventInit const& event_init);
static UIEvent* create(HTML::Window&, FlyString const& type);
static UIEvent* create_with_global_object(HTML::Window&, FlyString const& event_name, UIEventInit const& event_init);
UIEvent(Bindings::WindowObject&, FlyString const& event_name);
UIEvent(Bindings::WindowObject&, FlyString const& event_name, UIEventInit const& event_init);
UIEvent(HTML::Window&, FlyString const& event_name);
UIEvent(HTML::Window&, FlyString const& event_name, UIEventInit const& event_init);
virtual ~UIEvent() override;
UIEvent& impl() { return *this; }
HTML::Window const* view() const { return m_view; }
HTML::Window const* view() const { return m_view.ptr(); }
int detail() const { return m_detail; }
virtual u32 which() const { return 0; }
@ -43,7 +41,9 @@ public:
}
protected:
RefPtr<HTML::Window> m_view;
virtual void visit_edges(Cell::Visitor&) override;
JS::GCPtr<HTML::Window> m_view;
int m_detail { 0 };
};