RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 12:07:45 +00:00
Code Issues Activity Actions

LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated

Browse source 
This is a monster patch that turns all EventTargets into GC-allocated
PlatformObjects. Their C++ wrapper classes are removed, and the LibJS
garbage collector is now responsible for their lifetimes.

There's a fair amount of hacks and band-aids in this patch, and we'll
have a lot of cleanup to do after this.
This commit is contained in:
Andreas Kling 2022-08-28 13:42:07 +02:00
parent bb547ce1c4
commit 6f433c8656
445 changed files with 4797 additions and 4268 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Userland/Libraries/LibWeb/XHR/XMLHttpRequestEventTarget.h
View file

@ -6,7 +6,6 @@
#pragma once
#include <LibWeb/Bindings/EventTargetWrapperFactory.h>
#include <LibWeb/DOM/EventDispatcher.h>
#include <LibWeb/DOM/EventTarget.h>
@ -21,12 +20,10 @@ namespace Web::XHR {
E(ontimeout, XHR::EventNames::timeout) \
E(onloadend, XHR::EventNames::loadend)
class XMLHttpRequestEventTarget
: public DOM::EventTarget
, public Bindings::Wrappable {
public:
using WrapperType = Bindings::XMLHttpRequestEventTargetWrapper;
class XMLHttpRequestEventTarget : public DOM::EventTarget {
WEB_PLATFORM_OBJECT(XMLHttpRequestEventTarget, DOM::EventTarget);
public:
virtual ~XMLHttpRequestEventTarget() override {};
#undef __ENUMERATE
@ -37,16 +34,12 @@ public:
#undef __ENUMERATE
protected:
XMLHttpRequestEventTarget()
: DOM::EventTarget()
XMLHttpRequestEventTarget(JS::Realm& realm)
: DOM::EventTarget(realm)
{
}
private:
virtual JS::Object* create_wrapper(JS::Realm& realm) override
{
return wrap(realm, *this);
}
};
}
WRAPPER_HACK(XMLHttpRequestEventTarget, Web::XHR)