RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 03:07:36 +00:00
Code Issues Activity Actions

AK: Use size_t for the length of strings

Browse source 
Using int was a mistake. This patch changes String, StringImpl,
StringView and StringBuilder to use size_t instead of int for lengths.
Obviously a lot of code needs to change as a result of this.
This commit is contained in:
Andreas Kling 2019-12-09 17:45:40 +01:00
parent 1726c17d0d
commit 6f4c380d95
54 changed files with 387 additions and 377 deletions
Download patch file Download diff file Expand all files Collapse all files

14
AK/String.h
View file

@ -59,7 +59,7 @@ public:
{
}
String(const char* cstring, int length, ShouldChomp shouldChomp = NoChomp)
String(const char* cstring, size_t length, ShouldChomp shouldChomp = NoChomp)
: m_impl(StringImpl::create(cstring, length, shouldChomp))
{
}
@ -89,7 +89,7 @@ public:
CaseSensitive,
};
static String repeated(char, int count);
static String repeated(char, size_t count);
bool matches(const StringView& pattern, CaseSensitivity = CaseSensitivity::CaseInsensitive) const;
// FIXME: These should be shared between String and StringView somehow!
@ -112,18 +112,18 @@ public:
bool contains(const String&) const;
Vector<String> split_limit(char separator, int limit) const;
Vector<String> split_limit(char separator, size_t limit) const;
Vector<String> split(char separator) const;
String substring(int start, int length) const;
String substring(size_t start, size_t length) const;
Vector<StringView> split_view(char separator, bool keep_empty = false) const;
StringView substring_view(int start, int length) const;
StringView substring_view(size_t start, size_t length) const;
bool is_null() const { return !m_impl; }
bool is_empty() const { return length() == 0; }
int length() const { return m_impl ? m_impl->length() : 0; }
size_t length() const { return m_impl ? m_impl->length() : 0; }
const char* characters() const { return m_impl ? m_impl->characters() : nullptr; }
char operator[](int i) const
char operator[](size_t i) const
{
ASSERT(m_impl);
return (*m_impl)[i];