RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 20:37:36 +00:00
Code Issues Activity Actions

AK: Use size_t for the length of strings

Browse source 
Using int was a mistake. This patch changes String, StringImpl,
StringView and StringBuilder to use size_t instead of int for lengths.
Obviously a lot of code needs to change as a result of this.
This commit is contained in:
Andreas Kling 2019-12-09 17:45:40 +01:00
parent 1726c17d0d
commit 6f4c380d95
54 changed files with 387 additions and 377 deletions
Download patch file Download diff file Expand all files Collapse all files

4
DevTools/HackStudio/CppLexer.cpp
View file

@ -8,7 +8,7 @@ CppLexer::CppLexer(const StringView& input)
{
}
char CppLexer::peek(int offset) const
char CppLexer::peek(size_t offset) const
{
if ((m_index + offset) >= m_input.length())
return 0;
@ -191,7 +191,7 @@ Vector<CppToken> CppLexer::lex()
{
Vector<CppToken> tokens;
int token_start_index = 0;
size_t token_start_index = 0;
CppPosition token_start_position;
auto emit_token = [&](auto type) {

8
DevTools/HackStudio/CppLexer.h
View file

@ -25,8 +25,8 @@
__TOKEN(Identifier)
struct CppPosition {
int line { -1 };
int column { -1 };
size_t line;
size_t column;
};
struct CppToken {
@ -60,11 +60,11 @@ public:
Vector<CppToken> lex();
private:
char peek(int offset = 0) const;
char peek(size_t offset = 0) const;
char consume();
StringView m_input;
int m_index { 0 };
size_t m_index { 0 };
CppPosition m_previous_position { 0, 0 };
CppPosition m_position { 0, 0 };
};