RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 21:57:43 +00:00
Code Issues Activity Actions

AK: Use size_t for the length of strings

Browse source 
Using int was a mistake. This patch changes String, StringImpl,
StringView and StringBuilder to use size_t instead of int for lengths.
Obviously a lot of code needs to change as a result of this.
This commit is contained in:
Andreas Kling 2019-12-09 17:45:40 +01:00
parent 1726c17d0d
commit 6f4c380d95
54 changed files with 387 additions and 377 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Libraries/LibHTML/Parser/CSSParser.cpp
View file

@ -135,15 +135,15 @@ public:
bool next_is(const char* str) const
{
int len = strlen(str);
for (int i = 0; i < len; ++i) {
size_t len = strlen(str);
for (size_t i = 0; i < len; ++i) {
if (peek(i) != str[i])
return false;
}
return true;
}
char peek(int offset = 0) const
char peek(size_t offset = 0) const
{
if ((index + offset) < css.length())
return css[index + offset];
@ -169,7 +169,7 @@ public:
bool consume_whitespace_or_comments()
{
int original_index = index;
size_t original_index = index;
bool in_comment = false;
for (; index < css.length(); ++index) {
char ch = peek();
@ -582,7 +582,7 @@ private:
CurrentRule current_rule;
Vector<char> buffer;
int index = 0;
size_t index = 0;
StringView css;
};

6
Libraries/LibHTML/Parser/HTMLParser.cpp
View file

@ -129,8 +129,8 @@ static bool parse_html_document(const StringView& html, Document& document, Pare
}
};
for (int i = 0; i < html.length(); ++i) {
auto peek = [&](int offset) -> char {
for (size_t i = 0; i < html.length(); ++i) {
auto peek = [&](size_t offset) -> char {
if (i + offset >= html.length())
return '\0';
return html[i + offset];
@ -356,7 +356,7 @@ RefPtr<Document> parse_html_document(const StringView& html, const URL& url)
String escape_html_entities(const StringView& html)
{
StringBuilder builder;
for (int i = 0; i < html.length(); ++i) {
for (size_t i = 0; i < html.length(); ++i) {
if (html[i] == '<')
builder.append("&lt;");
else if (html[i] == '>')