RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 14:48:14 +00:00
Code Issues Activity Actions

AK: Use size_t for the length of strings

Browse source 
Using int was a mistake. This patch changes String, StringImpl,
StringView and StringBuilder to use size_t instead of int for lengths.
Obviously a lot of code needs to change as a result of this.
This commit is contained in:
Andreas Kling 2019-12-09 17:45:40 +01:00
parent 1726c17d0d
commit 6f4c380d95
54 changed files with 387 additions and 377 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Servers/TelnetServer/Client.cpp
View file

@ -1,3 +1,4 @@
#include "Client.h"
#include <AK/BufferStream.h>
#include <AK/ByteBuffer.h>
#include <AK/String.h>
@ -7,8 +8,7 @@
#include <LibCore/CNotifier.h>
#include <LibCore/CTCPSocket.h>
#include <stdio.h>
#include "Client.h"
#include <unistd.h>
Client::Client(int id, RefPtr<CTCPSocket> socket, int ptm_fd)
: m_id(id)
@ -56,7 +56,7 @@ void Client::drain_pty()
quit();
return;
}
send_data(StringView(buffer, nread));
send_data(StringView(buffer, (size_t)nread));
}
void Client::handle_data(const StringView& data)
@ -105,7 +105,7 @@ void Client::handle_error()
void Client::send_data(StringView data)
{
bool fast = true;
for (int i = 0; i < data.length(); i++) {
for (size_t i = 0; i < data.length(); i++) {
u8 c = data[i];
if (c == '\n' || c == 0xff)
fast = false;
@ -117,7 +117,7 @@ void Client::send_data(StringView data)
}
StringBuilder builder;
for (int i = 0; i < data.length(); i++) {
for (size_t i = 0; i < data.length(); i++) {
u8 c = data[i];
switch (c) {
@ -136,7 +136,6 @@ void Client::send_data(StringView data)
m_socket->write(builder.to_string());
}
void Client::send_command(Command command)
{
send_commands({ command });