RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 09:28:11 +00:00
Code Issues Activity Actions

AK: Use size_t for the length of strings

Browse source 
Using int was a mistake. This patch changes String, StringImpl,
StringView and StringBuilder to use size_t instead of int for lengths.
Obviously a lot of code needs to change as a result of this.
This commit is contained in:
Andreas Kling 2019-12-09 17:45:40 +01:00
parent 1726c17d0d
commit 6f4c380d95
54 changed files with 387 additions and 377 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Shell/Parser.cpp
View file

@ -48,7 +48,7 @@ void Parser::begin_redirect_write(int fd)
Vector<Command> Parser::parse()
{
for (int i = 0; i < m_input.length(); ++i) {
for (size_t i = 0; i < m_input.length(); ++i) {
char ch = m_input.characters()[i];
switch (m_state) {
case State::Free:
@ -107,7 +107,7 @@ Vector<Command> Parser::parse()
// redirection from zsh-style multi-digit fd, such as {10}>file
if (ch == '{') {
bool is_multi_fd_redirection = false;
int redir_end = i + 1;
size_t redir_end = i + 1;
while (redir_end < m_input.length()) {
char lookahead_ch = m_input.characters()[redir_end];