From 6f594b36f550ddfed614997e8fbdae39b49fb00d Mon Sep 17 00:00:00 2001 From: Aziz Berkay Yesilyurt Date: Tue, 6 Jul 2021 21:38:07 +0200 Subject: [PATCH] LibGUI: Verify m_window_id is not-zero in set_maximized Window::set_maximized requires non-zero window id to be a valid call, i.e. calling Window::show beforehand. A verify statement before the server call can help developers by hinting correct usage. --- Userland/Libraries/LibGUI/Window.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/Userland/Libraries/LibGUI/Window.cpp b/Userland/Libraries/LibGUI/Window.cpp index 019737f006..c2b29d3e7e 100644 --- a/Userland/Libraries/LibGUI/Window.cpp +++ b/Userland/Libraries/LibGUI/Window.cpp @@ -948,6 +948,7 @@ bool Window::is_maximized() const void Window::set_maximized(bool maximized) { + VERIFY(m_window_id != 0); WindowServerConnection::the().async_set_maximized(m_window_id, maximized); }