RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 16:18:12 +00:00
Code Issues Activity Actions

LibWeb: Don't collapse blocks into the previous sibling's padding

Browse source 
We were forgetting to account for the padding-bottom of the previous
relevant sibling when placing blocks vertically.
This commit is contained in:
Andreas Kling 2020-10-09 21:27:34 +02:00
parent 0aa74074dd
commit 6f74eaed42
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/Layout/LayoutBlock.cpp
View file

@ -647,7 +647,7 @@ void LayoutBlock::place_block_level_non_replaced_element_in_normal_flow(LayoutBl
}
if (relevant_sibling) {
y += relevant_sibling->effective_offset().y() + relevant_sibling->height();
y += relevant_sibling->effective_offset().y() + relevant_sibling->height() + relevant_sibling->box_model().padding.bottom.to_px(*relevant_sibling);
// Collapse top margin with bottom margin of preceding siblings if needed
float my_margin_top = box.margin.top.to_px(*this);