RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 06:37:44 +00:00
Code Issues Activity Actions

LibWeb: Use the specification defined types in IntersectionObserverInit

Browse source
This commit is contained in:
Idan Horowitz 2022-04-02 00:44:16 +03:00
parent b172b56757
commit 6f7cab91a7
2 changed files with 5 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/IntersectionObserver/IntersectionObserver.h
View file

@ -13,9 +13,9 @@
namespace Web::IntersectionObserver {
struct IntersectionObserverInit {
DOM::Node* root { nullptr };
Optional<Variant<NonnullRefPtr<DOM::Element>, NonnullRefPtr<DOM::Document>>> root;
String root_margin { "0px"sv };
JS::Value threshold { 0 };
Variant<double, Vector<double>> threshold { 0 };
};
// https://w3c.github.io/IntersectionObserver/#intersection-observer-interface

9
Userland/Libraries/LibWeb/IntersectionObserver/IntersectionObserver.idl
View file

@ -1,3 +1,4 @@
#import <DOM/Document.idl>
#import <DOM/Element.idl>
#import <DOM/Node.idl>
@ -16,11 +17,7 @@ interface IntersectionObserver {
};
dictionary IntersectionObserverInit {
// FIXME: Should be: (Element or Document)?
Node? root = null;
(Element or Document)? root = null;
DOMString rootMargin = "0px";
// FIXME: Should be: (double or sequence<double>)
any threshold = 0;
(double or sequence<double>) threshold = 0;
};