RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:27:35 +00:00
Code Issues Activity Actions

Kernel: Simplify interrupt management

Browse source 
The IRQController object is RefCounted, and is shared between the
InterruptManagement class & IRQ handlers' classes.

IRQHandler, SharedIRQHandler & SpuriousInterruptHandler classes
use a responsible IRQ controller directly instead of calling
InterruptManagement for disable(), enable() or eoi().

Also, the initialization process of InterruptManagement is
simplified, so it doesn't rely on an ACPI parser to be initialized.
This commit is contained in:
Liav A 2020-02-28 22:33:41 +02:00 • committed by Andreas Kling
parent f96cf250f9
commit 6f914ed0a4
9 changed files with 80 additions and 128 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Kernel/Interrupts/IRQHandler.cpp
View file

@ -34,6 +34,7 @@ namespace Kernel {
IRQHandler::IRQHandler(u8 irq)
: GenericInterruptHandler(irq)
, m_responsible_irq_controller(InterruptManagement::the().get_responsible_irq_controller(irq))
{
}
@ -47,7 +48,8 @@ bool IRQHandler::eoi()
dbg() << "EOI IRQ " << interrupt_number();
#endif
if (!m_shared_with_others) {
InterruptManagement::the().eoi(interrupt_number());
ASSERT(!m_responsible_irq_controller.is_null());
m_responsible_irq_controller->eoi(interrupt_number());
return true;
}
return false;
@ -59,7 +61,7 @@ void IRQHandler::enable_irq()
dbg() << "Enable IRQ " << interrupt_number();
#endif
if (!m_shared_with_others)
InterruptManagement::the().enable(interrupt_number());
m_responsible_irq_controller->enable(interrupt_number());
else
m_enabled = true;
}
@ -70,7 +72,7 @@ void IRQHandler::disable_irq()
dbg() << "Disable IRQ " << interrupt_number();
#endif
if (!m_shared_with_others)
InterruptManagement::the().disable(interrupt_number());
m_responsible_irq_controller->disable(interrupt_number());
else
m_enabled = false;
}
@ -79,6 +81,7 @@ void IRQHandler::change_irq_number(u8 irq)
{
InterruptDisabler disabler;
change_interrupt_number(irq);
m_responsible_irq_controller = InterruptManagement::the().get_responsible_irq_controller(irq);
}
}