RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 17:47:44 +00:00
Code Issues Activity Actions

Userland/tt: Use a default value for the test to run

Browse source 
Addresses #3394 which was caused by dereferencing null `test_name`
when no arguments were given to /bin/tt. Additionally, arguments
other than the defined tests now print usage and exit to avoid
running the default test.
This commit is contained in:
Avery 2020-09-02 22:35:19 -06:00 • committed by Andreas Kling
parent 27687b1c6e
commit 6fe37cb471
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/tt.cpp
View file

@ -41,7 +41,7 @@ static int set_stack_test();
int main(int argc, char** argv)
{
const char* test_name = nullptr;
const char* test_name = "n";
Core::ArgsParser args_parser;
args_parser.add_positional_argument(test_name, "Test to run (m = mutex, d = detached, p = priority, s = stack size, t = simple thread test, x = set stack, nothing = join race)", "test-name", Core::ArgsParser::Required::No);
@ -59,6 +59,10 @@ int main(int argc, char** argv)
return staying_alive_test();
if (*test_name == 'x')
return set_stack_test();
if (*test_name != 'n') {
args_parser.print_usage(stdout, argv[0]);
return 1;
}
printf("Hello from the first thread!\n");
pthread_t thread_id;