RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 09:38:11 +00:00
Code Issues Activity Actions

Oops, StringImpl's "the empty string" global was not always initialized.

Browse source 
These "oops forgot to initialize" bugs are getting annoying...
This commit is contained in:
Andreas Kling 2018-10-22 13:10:08 +02:00
parent c5e55f4737
commit 702d308e67
3 changed files with 14 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

13
AK/StringImpl.cpp
View file

@ -4,12 +4,17 @@
namespace AK {
static StringImpl* s_theEmptyStringImpl = nullptr;
void StringImpl::initializeGlobals()
{
s_theEmptyStringImpl = new StringImpl(ConstructTheEmptyStringImpl);;
}
StringImpl& StringImpl::theEmptyStringImpl()
{
static StringImpl* s = nullptr;
if (!s)
s = new StringImpl(ConstructTheEmptyStringImpl);
return *s;
ASSERT(s_theEmptyStringImpl);
return *s_theEmptyStringImpl;
}
StringImpl::~StringImpl()