RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 12:07:45 +00:00
Code Issues Activity Actions

Browser: Convert JS ConsoleWidget to new API

Browse source 
The console widget now requests messages and receives them in bulk,
using the shiny new IPC calls. This lets it display console messages
that occurred before the widget was created. :^)
This commit is contained in:
Sam Atkins 2021-09-04 12:12:12 +01:00 • committed by Andreas Kling
parent f6a927fa20
commit 703bd4c9da
3 changed files with 88 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Userland/Applications/Browser/Tab.cpp
View file

@ -180,7 +180,7 @@ Tab::Tab(BrowserWindow& window)
m_dom_inspector_widget->clear_dom_json();
if (m_console_widget)
m_console_widget->clear_output();
m_console_widget->reset();
};
hooks().on_load_finish = [this](auto&) {
@ -301,9 +301,14 @@ Tab::Tab(BrowserWindow& window)
m_dom_inspector_widget->set_dom_node_properties_json(node_id, specified, computed);
};
hooks().on_js_console_output = [this](auto& method, auto& line) {
hooks().on_js_console_new_message = [this](auto message_index) {
if (m_console_widget)
m_console_widget->handle_js_console_output(method, line);
m_console_widget->notify_about_new_console_message(message_index);
};
hooks().on_get_js_console_messages = [this](auto start_index, auto& message_types, auto& messages) {
if (m_console_widget)
m_console_widget->handle_console_messages(start_index, message_types, messages);
};
auto focus_location_box_action = GUI::Action::create(
@ -520,6 +525,9 @@ void Tab::show_console_window()
m_console_widget->on_js_input = [this](String const& js_source) {
m_web_content_view->js_console_input(js_source);
};
m_console_widget->on_request_messages = [this](i32 start_index) {
m_web_content_view->js_console_request_messages(start_index);
};
m_web_content_view->js_console_initialize();
}