From 705b7fc4077798e4871783580e9645248aafe446 Mon Sep 17 00:00:00 2001 From: Sam Atkins Date: Thu, 25 Nov 2021 16:52:08 +0000 Subject: [PATCH] Browser: Allow custom search engine URLs that don't start http[s]:// --- Userland/Applications/Browser/Tab.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/Userland/Applications/Browser/Tab.cpp b/Userland/Applications/Browser/Tab.cpp index 2463a7e21d..ca65ca6803 100644 --- a/Userland/Applications/Browser/Tab.cpp +++ b/Userland/Applications/Browser/Tab.cpp @@ -40,16 +40,17 @@ namespace Browser { URL url_from_user_input(const String& input) { - if (input.starts_with("?") && !g_search_engine.is_null()) - return URL(g_search_engine.replace("{}", URL::percent_encode(input.substring_view(1)))); + String url_string = input; + if (input.starts_with("?") && !g_search_engine.is_empty()) + url_string = g_search_engine.replace("{}", URL::percent_encode(input.substring_view(1))); - auto url = URL(input); + URL url = URL(url_string); if (url.is_valid()) return url; StringBuilder builder; builder.append("http://"); - builder.append(input); + builder.append(url_string); return URL(builder.build()); }