RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 23:47:45 +00:00
Code Issues Activity Actions

DevTools: Use default constructors/destructors

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-02-15 13:28:01 -07:00 • committed by Tim Flynn
parent 84f87a9f76
commit 7070713ec8
50 changed files with 75 additions and 122 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/DevTools/HackStudio/Dialogs/NewProjectDialog.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2021, Nick Vella <nick@nxk.io>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -101,10 +102,6 @@ NewProjectDialog::NewProjectDialog(GUI::Window* parent)
};
}
NewProjectDialog::~NewProjectDialog()
{
}
RefPtr<ProjectTemplate> NewProjectDialog::selected_template()
{
if (m_icon_view->selection().is_empty()) {

3
Userland/DevTools/HackStudio/Dialogs/NewProjectDialog.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2021, Nick Vella <nick@nxk.io>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -27,7 +28,7 @@ public:
private:
NewProjectDialog(GUI::Window* parent);
virtual ~NewProjectDialog() override;
virtual ~NewProjectDialog() override = default;
void update_dialog();
Optional<String> get_available_project_name();

5
Userland/DevTools/HackStudio/Dialogs/ProjectTemplatesModel.cpp
View file

@ -1,6 +1,7 @@
/*
* Copyright (c) 2021, Nick Vella <nick@nxk.io>
* Copyright (c) 2021, sin-ack <sin-ack@protonmail.com>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -42,10 +43,6 @@ ProjectTemplatesModel::ProjectTemplatesModel()
rescan_templates();
}
ProjectTemplatesModel::~ProjectTemplatesModel()
{
}
int ProjectTemplatesModel::row_count(const GUI::ModelIndex&) const
{
return m_mapping.size();

3
Userland/DevTools/HackStudio/Dialogs/ProjectTemplatesModel.h
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2021, Nick Vella <nick@nxk.io>
* Copyright (c) 2022, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -29,7 +30,7 @@ public:
__Count
};
virtual ~ProjectTemplatesModel() override;
virtual ~ProjectTemplatesModel() override = default;
RefPtr<ProjectTemplate> template_for_index(const GUI::ModelIndex& index);