RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 06:24:58 +00:00
Code Issues Activity Actions

LibC: Set sin_port in network order in getaddrinfo results

Browse source 
This is required by POSIX, and we were already doing it for the numeric
service case, but not for the named service case.
This commit is contained in:
Idan Horowitz 2023-12-24 19:22:52 +02:00 • committed by Andreas Kling
parent dca5c71e53
commit 70779e43ed
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibC/netdb.cpp
View file

@ -891,11 +891,11 @@ int getaddrinfo(char const* __restrict node, char const* __restrict service, con
if (!service_file_line.has_value()) {
if (service) {
char* end;
port = htons(strtol(service, &end, 10));
port = strtol(service, &end, 10);
if (*end)
return EAI_FAIL;
} else {
port = htons(0);
port = 0;
}
if (hints && hints->ai_socktype != 0)
@ -913,7 +913,7 @@ int getaddrinfo(char const* __restrict node, char const* __restrict service, con
for (int host_index = 0; host_ent->h_addr_list[host_index]; host_index++) {
sockaddr_in* sin = new sockaddr_in;
sin->sin_family = AF_INET;
sin->sin_port = port;
sin->sin_port = htons(port);
memcpy(&sin->sin_addr.s_addr, host_ent->h_addr_list[host_index], host_ent->h_length);
addrinfo* info = new addrinfo;