RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 02:17:35 +00:00
Code Issues Activity Actions

Refactor: Change the AK::binary_search signature to use AK::Span.

Browse source
This commit is contained in:
asynts 2020-07-26 11:22:05 +02:00 • committed by Andreas Kling
parent ac9c2bc492
commit 707d92db61
5 changed files with 20 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

28
AK/Tests/TestBinarySearch.cpp
View file

@ -36,9 +36,9 @@ TEST_CASE(vector_ints)
ints.append(2);
ints.append(3);
auto test1 = *binary_search(ints.data(), ints.size(), 1, AK::integral_compare<int>);
auto test2 = *binary_search(ints.data(), ints.size(), 2, AK::integral_compare<int>);
auto test3 = *binary_search(ints.data(), ints.size(), 3, AK::integral_compare<int>);
auto test1 = *binary_search(ints.span(), 1, AK::integral_compare<int>);
auto test2 = *binary_search(ints.span(), 2, AK::integral_compare<int>);
auto test3 = *binary_search(ints.span(), 3, AK::integral_compare<int>);
EXPECT_EQ(test1, 1);
EXPECT_EQ(test2, 2);
EXPECT_EQ(test3, 3);
@ -48,9 +48,9 @@ TEST_CASE(array_doubles)
{
double doubles[] = { 1.1, 9.9, 33.33 };
auto test1 = *binary_search(doubles, 3, 1.1, AK::integral_compare<double>);
auto test2 = *binary_search(doubles, 3, 9.9, AK::integral_compare<double>);
auto test3 = *binary_search(doubles, 3, 33.33, AK::integral_compare<double>);
auto test1 = *binary_search({ doubles, 3 }, 1.1, AK::integral_compare<double>);
auto test2 = *binary_search({ doubles, 3 }, 9.9, AK::integral_compare<double>);
auto test3 = *binary_search({ doubles, 3 }, 33.33, AK::integral_compare<double>);
EXPECT_EQ(test1, 1.1);
EXPECT_EQ(test2, 9.9);
EXPECT_EQ(test3, 33.33);
@ -66,9 +66,9 @@ TEST_CASE(vector_strings)
auto string_compare = [](const String& a, const String& b) -> int {
return strcmp(a.characters(), b.characters());
};
auto test1 = *binary_search(strings.data(), strings.size(), String("bat"), string_compare);
auto test2 = *binary_search(strings.data(), strings.size(), String("cat"), string_compare);
auto test3 = *binary_search(strings.data(), strings.size(), String("dog"), string_compare);
auto test1 = *binary_search(strings.span(), String("bat"), string_compare);
auto test2 = *binary_search(strings.span(), String("cat"), string_compare);
auto test3 = *binary_search(strings.span(), String("dog"), string_compare);
EXPECT_EQ(test1, String("bat"));
EXPECT_EQ(test2, String("cat"));
EXPECT_EQ(test3, String("dog"));
@ -79,7 +79,7 @@ TEST_CASE(single_element)
Vector<int> ints;
ints.append(1);
auto test1 = *binary_search(ints.data(), ints.size(), 1, AK::integral_compare<int>);
auto test1 = *binary_search(ints.span(), 1, AK::integral_compare<int>);
EXPECT_EQ(test1, 1);
}
@ -90,9 +90,9 @@ TEST_CASE(not_found)
ints.append(2);
ints.append(3);
auto test1 = binary_search(ints.data(), ints.size(), -1, AK::integral_compare<int>);
auto test2 = binary_search(ints.data(), ints.size(), 0, AK::integral_compare<int>);
auto test3 = binary_search(ints.data(), ints.size(), 4, AK::integral_compare<int>);
auto test1 = binary_search(ints.span(), -1, AK::integral_compare<int>);
auto test2 = binary_search(ints.span(), 0, AK::integral_compare<int>);
auto test3 = binary_search(ints.span(), 4, AK::integral_compare<int>);
EXPECT_EQ(test1, nullptr);
EXPECT_EQ(test2, nullptr);
EXPECT_EQ(test3, nullptr);
@ -102,7 +102,7 @@ TEST_CASE(no_elements)
{
Vector<int> ints;
auto test1 = binary_search(ints.data(), ints.size(), 1, AK::integral_compare<int>);
auto test1 = binary_search(ints.span(), 1, AK::integral_compare<int>);
EXPECT_EQ(test1, nullptr);
}