From 70e8a9bc8bbe54d5abde78ec68c48ba3bf9a146b Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Thu, 26 Jan 2023 16:15:49 +0000 Subject: [PATCH] LibJS: Remove unused is_valid_time_zone_numeric_utc_offset_syntax() ...as well as the underlying function: parse_time_zone_numeric_utc_offset_syntax() --- .../LibJS/Runtime/Temporal/TimeZone.cpp | 44 ------------------- .../LibJS/Runtime/Temporal/TimeZone.h | 2 - 2 files changed, 46 deletions(-) diff --git a/Userland/Libraries/LibJS/Runtime/Temporal/TimeZone.cpp b/Userland/Libraries/LibJS/Runtime/Temporal/TimeZone.cpp index 7f147a4127..6645f4d7a2 100644 --- a/Userland/Libraries/LibJS/Runtime/Temporal/TimeZone.cpp +++ b/Userland/Libraries/LibJS/Runtime/Temporal/TimeZone.cpp @@ -4,7 +4,6 @@ * SPDX-License-Identifier: BSD-2-Clause */ -#include #include #include #include @@ -165,49 +164,6 @@ BigInt* get_named_time_zone_previous_transition(VM&, [[maybe_unused]] StringView return nullptr; } -// https://tc39.es/proposal-temporal/#prod-TimeZoneNumericUTCOffset -static bool parse_time_zone_numeric_utc_offset_syntax(DeprecatedString const& offset_string, StringView& sign, StringView& hours, Optional& minutes, Optional& seconds, Optional& fraction) -{ - DateTimeLexer lexer(offset_string); - auto sign_part = lexer.consume_sign(); - if (!sign_part.has_value()) - return false; - sign = *sign_part; - auto hours_part = lexer.consume_hours(); - if (!hours_part.has_value()) - return false; - hours = *hours_part; - if (!lexer.tell_remaining()) - return true; - auto uses_separator = lexer.consume_specific(':'); - minutes = lexer.consume_minutes_or_seconds(); - if (!minutes.has_value()) - return false; - if (!lexer.tell_remaining()) - return true; - if (lexer.consume_specific(':') != uses_separator) - return false; - seconds = lexer.consume_minutes_or_seconds(); - if (!seconds.has_value()) - return false; - if (!lexer.tell_remaining()) - return true; - if (!lexer.consume_specific('.') && !lexer.consume_specific(',')) - return false; - fraction = lexer.consume_fractional_seconds(); - if (!fraction.has_value()) - return false; - return !lexer.tell_remaining(); -} - -bool is_valid_time_zone_numeric_utc_offset_syntax(DeprecatedString const& offset_string) -{ - StringView discarded; - Optional optionally_discarded; - // FIXME: This is very wasteful - return parse_time_zone_numeric_utc_offset_syntax(offset_string, discarded, discarded, optionally_discarded, optionally_discarded, optionally_discarded); -} - // 11.6.5 FormatTimeZoneOffsetString ( offsetNanoseconds ), https://tc39.es/proposal-temporal/#sec-temporal-formattimezoneoffsetstring ThrowCompletionOr format_time_zone_offset_string(VM& vm, double offset_nanoseconds) { diff --git a/Userland/Libraries/LibJS/Runtime/Temporal/TimeZone.h b/Userland/Libraries/LibJS/Runtime/Temporal/TimeZone.h index 25f0cf7803..e94a313ad2 100644 --- a/Userland/Libraries/LibJS/Runtime/Temporal/TimeZone.h +++ b/Userland/Libraries/LibJS/Runtime/Temporal/TimeZone.h @@ -53,6 +53,4 @@ ThrowCompletionOr disambiguate_possible_instants(VM&, MarkedVector> get_possible_instants_for(VM&, Value time_zone, PlainDateTime&); ThrowCompletionOr time_zone_equals(VM&, Object& one, Object& two); -bool is_valid_time_zone_numeric_utc_offset_syntax(DeprecatedString const&); - }