RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-01 09:58:14 +00:00
Code Issues Activity Actions

Shell: Allow lossy conversion from list -> string in POSIX mode

Browse source 
Similar to bash, this operation returns only the first element because
reasons.
This commit is contained in:
Ali Mohammad Pur 2023-04-19 12:16:45 +03:30 • committed by Ali Mohammad Pur
parent 8a042cd9cb
commit 71441ea932
2 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Userland/Shell/AST.cpp
View file

@ -3691,6 +3691,17 @@ ErrorOr<Vector<String>> ListValue::resolve_as_list(RefPtr<Shell> shell)
return resolve_slices(shell, move(values), m_slices);
}
ErrorOr<String> ListValue::resolve_as_string(RefPtr<Shell> shell)
{
if (!shell || !shell->posix_mode())
return Value::resolve_as_string(shell);
if (m_contained_values.is_empty())
return resolve_slices(shell, String {}, m_slices);
return resolve_slices(shell, TRY(m_contained_values[0]->resolve_as_string(shell)), m_slices);
}
ErrorOr<NonnullRefPtr<Value>> ListValue::resolve_without_cast(RefPtr<Shell> shell)
{
Vector<NonnullRefPtr<Value>> values;

1
Userland/Shell/AST.h
View file

@ -310,6 +310,7 @@ private:
class ListValue final : public Value {
public:
virtual ErrorOr<Vector<String>> resolve_as_list(RefPtr<Shell>) override;
virtual ErrorOr<String> resolve_as_string(RefPtr<Shell>) override;
virtual ErrorOr<NonnullRefPtr<Value>> resolve_without_cast(RefPtr<Shell>) override;
virtual ErrorOr<NonnullRefPtr<Value>> clone() const override { return TRY(try_make_ref_counted<ListValue>(m_contained_values))->set_slices(m_slices); }
virtual ~ListValue();