RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 22:07:35 +00:00
Code Issues Activity Actions

LibWeb: Move "has-definite-width/height" flags to UsedValues

Browse source 
This state is less static than we originally assumed, and there are
special formatting context-specific rules that say certain sizes are
definite in special circumstances.

To be able to support this, we move the has-definite-size flags from
the layout node to the UsedValues struct instead.
This commit is contained in:
Andreas Kling 2022-07-17 18:46:38 +02:00
parent 25e6ad8d3e
commit 71a707480c
8 changed files with 71 additions and 70 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibWeb/Layout/Node.h
View file

@ -169,12 +169,6 @@ public:
NonnullRefPtr<NodeWithStyle> create_anonymous_wrapper() const;
bool has_definite_height() const { return m_has_definite_height; }
bool has_definite_width() const { return m_has_definite_width; }
void set_has_definite_height(bool b) { m_has_definite_height = b; }
void set_has_definite_width(bool b) { m_has_definite_width = b; }
void did_insert_into_layout_tree(CSS::StyleProperties const&);
protected:
@ -186,9 +180,6 @@ private:
RefPtr<Gfx::Font> m_font;
float m_line_height { 0 };
RefPtr<CSS::ImageStyleValue> m_list_style_image;
bool m_has_definite_height { false };
bool m_has_definite_width { false };
};
class NodeWithStyleAndBoxModelMetrics : public NodeWithStyle {