From 71aba39562712caa527d064b683ccaca2d7eaf08 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Wed, 9 Nov 2022 12:43:01 -0500 Subject: [PATCH] Browser: Remove unused WebDriver IPC endpoints I had originally thought to just leave these and remove them all at once at the end of the WebContent migration. But it is kind of confusing to have them around, so this removes the endpoints that have already been ported. --- .../Applications/Browser/WebDriverConnection.cpp | 15 --------------- .../Applications/Browser/WebDriverConnection.h | 2 -- .../Browser/WebDriverSessionClient.ipc | 2 -- 3 files changed, 19 deletions(-) diff --git a/Userland/Applications/Browser/WebDriverConnection.cpp b/Userland/Applications/Browser/WebDriverConnection.cpp index e5d2980762..8b516ae28e 100644 --- a/Userland/Applications/Browser/WebDriverConnection.cpp +++ b/Userland/Applications/Browser/WebDriverConnection.cpp @@ -29,21 +29,6 @@ void WebDriverConnection::quit() browser_window->close(); } -Messages::WebDriverSessionClient::GetUrlResponse WebDriverConnection::get_url() -{ - dbgln_if(WEBDRIVER_DEBUG, "WebDriverConnection: get_url"); - if (auto browser_window = m_browser_window.strong_ref()) - return { browser_window->active_tab().url() }; - return { URL("") }; -} - -void WebDriverConnection::set_url(AK::URL const& url) -{ - dbgln_if(WEBDRIVER_DEBUG, "WebDriverConnection: set_url {}", url); - if (auto browser_window = m_browser_window.strong_ref()) - browser_window->active_tab().load(url); -} - Messages::WebDriverSessionClient::GetTitleResponse WebDriverConnection::get_title() { dbgln_if(WEBDRIVER_DEBUG, "WebDriverConnection: get_title"); diff --git a/Userland/Applications/Browser/WebDriverConnection.h b/Userland/Applications/Browser/WebDriverConnection.h index 76b521bf07..040b263333 100644 --- a/Userland/Applications/Browser/WebDriverConnection.h +++ b/Userland/Applications/Browser/WebDriverConnection.h @@ -38,8 +38,6 @@ public: virtual void die() override { } virtual void quit() override; - virtual Messages::WebDriverSessionClient::GetUrlResponse get_url() override; - virtual void set_url(AK::URL const& url) override; virtual Messages::WebDriverSessionClient::GetTitleResponse get_title() override; virtual void refresh() override; virtual void back() override; diff --git a/Userland/Applications/Browser/WebDriverSessionClient.ipc b/Userland/Applications/Browser/WebDriverSessionClient.ipc index 76fc2f25ab..fe5f3a866b 100644 --- a/Userland/Applications/Browser/WebDriverSessionClient.ipc +++ b/Userland/Applications/Browser/WebDriverSessionClient.ipc @@ -14,8 +14,6 @@ endpoint WebDriverSessionClient { quit() =| - get_url() => (URL url) - set_url(URL url) =| get_title() => (String title) refresh() =| back() =|