1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 12:37:44 +00:00

Meta/Lagom: Make sure that libraries are always linked as PRIVATE

This commit is contained in:
Sam Atkins 2023-01-15 21:12:11 +00:00 committed by Linus Groh
parent a4c8353472
commit 71af0c296f

View file

@ -251,7 +251,7 @@ function(lagom_test source)
cmake_parse_arguments(LAGOM_TEST "" "WORKING_DIRECTORY" "LIBS" ${ARGN}) cmake_parse_arguments(LAGOM_TEST "" "WORKING_DIRECTORY" "LIBS" ${ARGN})
get_filename_component(name ${source} NAME_WE) get_filename_component(name ${source} NAME_WE)
add_executable(${name} ${source}) add_executable(${name} ${source})
target_link_libraries(${name} LibCore LibTest LibTestMain ${LAGOM_TEST_LIBS}) target_link_libraries(${name} PRIVATE LibCore LibTest LibTestMain ${LAGOM_TEST_LIBS})
add_test( add_test(
NAME ${name} NAME ${name}
COMMAND ${name} COMMAND ${name}
@ -562,7 +562,7 @@ if (BUILD_LAGOM)
foreach(source ${AK_TEST_SOURCES}) foreach(source ${AK_TEST_SOURCES})
lagom_test(${source} WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/../../Tests/AK) lagom_test(${source} WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/../../Tests/AK)
endforeach() endforeach()
target_link_libraries(TestString LibUnicode) target_link_libraries(TestString PRIVATE LibUnicode)
# LibAudio # LibAudio
file(GLOB LIBAUDIO_TEST_SOURCES CONFIGURE_DEPENDS "../../Tests/LibAudio/*.cpp") file(GLOB LIBAUDIO_TEST_SOURCES CONFIGURE_DEPENDS "../../Tests/LibAudio/*.cpp")