RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 13:17:35 +00:00
Code Issues Activity Actions

LibJS: Use AK::String::index_of() for StringPrototype::index_of()

Browse source
This commit is contained in:
Linus Groh 2020-04-18 21:08:23 +01:00 • committed by Andreas Kling
parent bf5b251684
commit 71d6459b7f
1 changed files with 1 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Libraries/LibJS/Runtime/StringPrototype.cpp
View file

@ -138,12 +138,7 @@ Value StringPrototype::index_of(Interpreter& interpreter)
needle_value = interpreter.argument(0); needle_value = interpreter.argument(0);
auto needle = needle_value.to_string(); auto needle = needle_value.to_string();
auto haystack = static_cast<const StringObject*>(this_object)->primitive_string()->string(); auto haystack = static_cast<const StringObject*>(this_object)->primitive_string()->string();
return Value((i32)haystack.index_of(needle).value_or(-1));
// FIXME: We should have a helper in AK::String for this.
auto* ptr = strstr(haystack.characters(), needle.characters());
if (!ptr)
return Value(-1);
return Value((i32)(ptr - haystack.characters()));
} }
static StringObject* string_object_from(Interpreter& interpreter) static StringObject* string_object_from(Interpreter& interpreter)