From 71da52482c0b190898805bc20b3b0e138d8ad258 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sat, 6 Jun 2020 14:06:37 +0200 Subject: [PATCH] LibWeb: Show error page if we can't handle a frame's main resource If we can't figure out how to make a Document for the main resource in a Frame, just show an error page. --- Libraries/LibWeb/Loader/FrameLoader.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Libraries/LibWeb/Loader/FrameLoader.cpp b/Libraries/LibWeb/Loader/FrameLoader.cpp index f855229698..afd595bfaf 100644 --- a/Libraries/LibWeb/Loader/FrameLoader.cpp +++ b/Libraries/LibWeb/Loader/FrameLoader.cpp @@ -221,7 +221,12 @@ void FrameLoader::resource_did_load() dbg() << "I believe this content has MIME type '" << resource()->mime_type() << "', encoding '" << resource()->encoding() << "'"; auto document = create_document_from_mime_type(resource()->encoded_data(), url, resource()->mime_type(), resource()->encoding()); - ASSERT(document); + + if (!document) { + load_error_page(url, "Failed to parse content."); + return; + } + frame().set_document(document); if (!url.fragment().is_empty())