RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 18:17:44 +00:00
Code Issues Activity Actions

Kernel/FileSystem: Simplify the ProcFS inode code

Browse source 
This is done by merging all scattered pieces of derived classes from the
ProcFSInode class into that one class, so we don't use inheritance but
rather simplistic checks to determine the proper code for each ProcFS
inode with its specific characteristics.
This commit is contained in:
Liav A 2022-11-25 22:29:27 +02:00 • committed by Jelle Raaijmakers
parent e9dcc49f9c
commit 722ae35329
25 changed files with 583 additions and 913 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Kernel/ProcessExposed.h
View file

@ -86,7 +86,7 @@ public:
return {};
}
virtual ErrorOr<NonnullLockRefPtr<Inode>> to_inode(ProcFS const& procfs_instance) const = 0;
virtual ErrorOr<NonnullLockRefPtr<ProcFSInode>> to_inode(ProcFS const& procfs_instance) const = 0;
virtual InodeIndex component_index() const { return m_component_index; }
@ -119,7 +119,7 @@ public:
}
virtual mode_t required_mode() const override { return 0555; }
virtual ErrorOr<NonnullLockRefPtr<Inode>> to_inode(ProcFS const& procfs_instance) const override final;
virtual ErrorOr<NonnullLockRefPtr<ProcFSInode>> to_inode(ProcFS const& procfs_instance) const override final;
protected:
explicit ProcFSExposedDirectory(StringView name);
@ -130,7 +130,7 @@ protected:
class ProcFSExposedLink : public ProcFSExposedComponent {
public:
virtual ErrorOr<NonnullLockRefPtr<Inode>> to_inode(ProcFS const& procfs_instance) const override final;
virtual ErrorOr<NonnullLockRefPtr<ProcFSInode>> to_inode(ProcFS const& procfs_instance) const override final;
virtual ErrorOr<size_t> read_bytes(off_t offset, size_t count, UserOrKernelBuffer& buffer, OpenFileDescription* description) const override;