RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 07:27:45 +00:00
Code Issues Activity Actions

WindowServer+LibGUI: Coalesce multiple client paints into GMultiPaintEvents.

Browse source 
This allows GWindow to paint up to 32 separate rects before telling the
WindowServer to flip the buffers. Quite a bit smoother. :^)
This commit is contained in:
Andreas Kling 2019-04-20 17:37:28 +02:00
parent 7efd61fcf5
commit 7234900f61
6 changed files with 54 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Servers/WindowServer/WSClientConnection.cpp
View file

@ -515,7 +515,8 @@ void WSClientConnection::handle_request(const WSAPIDidFinishPaintingNotification
return;
}
auto& window = *(*it).value;
WSWindowManager::the().invalidate(window, request.rect());
for (auto& rect : request.rects())
WSWindowManager::the().invalidate(window, rect);
}
void WSClientConnection::handle_request(const WSAPIGetWindowBackingStoreRequest& request)

8
Servers/WindowServer/WSEvent.h
View file

@ -595,19 +595,19 @@ private:
class WSAPIDidFinishPaintingNotification final : public WSAPIClientRequest {
public:
explicit WSAPIDidFinishPaintingNotification(int client_id, int window_id, const Rect& rect)
explicit WSAPIDidFinishPaintingNotification(int client_id, int window_id, const Vector<Rect, 32>& rects)
: WSAPIClientRequest(WSEvent::APIDidFinishPaintingNotification, client_id)
, m_window_id(window_id)
, m_rect(rect)
, m_rects(rects)
{
}
int window_id() const { return m_window_id; }
Rect rect() const { return m_rect; }
const Vector<Rect, 32>& rects() const { return m_rects; }
private:
int m_window_id { 0 };
Rect m_rect;
Vector<Rect, 32> m_rects;
};
enum class MouseButton : byte {

9
Servers/WindowServer/WSEventLoop.cpp
View file

@ -199,9 +199,14 @@ void WSEventLoop::on_receive_from_client(int client_id, const WSAPI_ClientMessag
post_event(client, make<WSAPIInvalidateRectRequest>(client_id, message.window_id, rects));
break;
}
case WSAPI_ClientMessage::Type::DidFinishPainting:
post_event(client, make<WSAPIDidFinishPaintingNotification>(client_id, message.window_id, message.window.rect));
case WSAPI_ClientMessage::Type::DidFinishPainting: {
Vector<Rect, 32> rects;
ASSERT(message.rect_count <= 32);
for (int i = 0; i < message.rect_count; ++i)
rects.append(message.rects[i]);
post_event(client, make<WSAPIDidFinishPaintingNotification>(client_id, message.window_id, rects));
break;
}
case WSAPI_ClientMessage::Type::GetWindowBackingStore:
post_event(client, make<WSAPIGetWindowBackingStoreRequest>(client_id, message.window_id));
break;