RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 18:28:12 +00:00
Code Issues Activity Actions

Meta: Scale back overly informal user-facing strings

Browse source 
We were getting a little overly memey in some places, so let's scale
things back to business-casual.

Informal language is fine in comments, commits and debug logs,
but let's keep the runtime nice and presentable. :^)
This commit is contained in:
Andreas Kling 2020-06-17 18:20:28 +02:00
parent d7bf609376
commit 723f4e5ee6
8 changed files with 15 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Userland/cat.cpp
View file

@ -35,21 +35,6 @@
#include <string.h>
#include <unistd.h>
bool detect_useless_use_of_cat(int argc)
{
// I can think of somewhat valid uses of zero-argument cat
// from a tty to a pipe, so let's allow those.
if (argc != 2)
return false;
struct stat statbuf;
int rc = fstat(1, &statbuf);
if (rc < 0)
return false;
return S_ISFIFO(statbuf.st_mode);
}
int main(int argc, char** argv)
{
if (pledge("stdio rpath", nullptr) < 0) {
@ -63,9 +48,6 @@ int main(int argc, char** argv)
args_parser.add_positional_argument(paths, "File path", "path", Core::ArgsParser::Required::No);
args_parser.parse(argc, argv);
if (detect_useless_use_of_cat(argc))
fprintf(stderr, "\033[34;1mMeow! Useless use of cat detected\033[0m\n");
Vector<int> fds;
if (!paths.is_empty()) {
for (const char* path : paths) {