RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-20 13:55:08 +00:00
Code Issues Activity Actions

LibWeb: Add logical-alias-for in Properties.json

Browse source 
This allows for succint definitions of logical properties, by allowing
them to inherit initial values, valid identifiers, etc from another
property
This commit is contained in:
Karthik Karanth 2023-05-25 23:57:09 -07:00 • committed by Andreas Kling
parent e78d1ec03a
commit 72507c318a
1 changed files with 34 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

34
Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateCSSPropertyID.cpp
View file

@ -12,6 +12,7 @@
#include <LibCore/ArgsParser.h> #include <LibCore/ArgsParser.h>
#include <LibMain/Main.h> #include <LibMain/Main.h>
ErrorOr<void> replace_logical_aliases(JsonObject& properties);
ErrorOr<void> generate_header_file(JsonObject& properties, Core::File& file); ErrorOr<void> generate_header_file(JsonObject& properties, Core::File& file);
ErrorOr<void> generate_implementation_file(JsonObject& properties, Core::File& file); ErrorOr<void> generate_implementation_file(JsonObject& properties, Core::File& file);
@ -36,6 +37,8 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
VERIFY(json.is_object()); VERIFY(json.is_object());
auto properties = json.as_object(); auto properties = json.as_object();
TRY(replace_logical_aliases(properties));
auto generated_header_file = TRY(Core::File::open(generated_header_path, Core::File::OpenMode::Write)); auto generated_header_file = TRY(Core::File::open(generated_header_path, Core::File::OpenMode::Write));
auto generated_implementation_file = TRY(Core::File::open(generated_implementation_path, Core::File::OpenMode::Write)); auto generated_implementation_file = TRY(Core::File::open(generated_implementation_path, Core::File::OpenMode::Write));
@ -45,6 +48,37 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
return 0; return 0;
} }
ErrorOr<void> replace_logical_aliases(JsonObject& properties)
{
AK::HashMap<DeprecatedString, DeprecatedString> logical_aliases;
properties.for_each_member([&](auto& name, auto& value) {
VERIFY(value.is_object());
const auto& value_as_object = value.as_object();
const auto logical_alias_for = value_as_object.get_deprecated_string("logical-alias-for"sv);
if (logical_alias_for.has_value()) {
logical_aliases.set(name, logical_alias_for.value());
}
});
for (auto& [name, alias] : logical_aliases) {
auto const maybe_alias_object = properties.get_object(alias);
if (!maybe_alias_object.has_value()) {
dbgln("No property '{}' found for logical alias '{}'", alias, name);
VERIFY_NOT_REACHED();
}
JsonObject alias_object = maybe_alias_object.value();
// Copy over anything the logical property overrides
properties.get_object(name).value().for_each_member([&](auto& key, auto& value) {
alias_object.set(key, value);
});
properties.set(name, alias_object);
}
return {};
}
ErrorOr<void> generate_header_file(JsonObject& properties, Core::File& file) ErrorOr<void> generate_header_file(JsonObject& properties, Core::File& file)
{ {
StringBuilder builder; StringBuilder builder;