RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 20:07:34 +00:00
Code Issues Activity Actions

LibJS: Define IsValidTimeZoneName in terms of AvailableTimeZones

Browse source 
This is an editorial change in the Temporal spec.

See: d83dcf0

Note that even though we already implement AvailableTimeZones for Intl,
I kept the existing implementation calling into LibTimeZone directly.
This commit is contained in:
Linus Groh 2022-10-17 09:08:20 +02:00
parent fefe447cf5
commit 72997c6b77
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibJS/Runtime/Temporal/TimeZone.cpp
View file

@ -28,11 +28,11 @@ TimeZone::TimeZone(Object& prototype)
}
// 11.1.1 IsValidTimeZoneName ( timeZone ), https://tc39.es/proposal-temporal/#sec-isvalidtimezonename
// 15.1.1 IsValidTimeZoneName ( timeZone ), https://tc39.es/proposal-temporal/#sup-isvalidtimezonename
bool is_valid_time_zone_name(String const& time_zone)
bool is_valid_time_zone_name(StringView time_zone)
{
// 1. If one of the Zone or Link names of the IANA Time Zone Database is an ASCII-case-insensitive match of timeZone as described in 6.1, return true.
// 2. If timeZone is an ASCII-case-insensitive match of "UTC", return true.
// 1. Let timeZones be AvailableTimeZones().
// 2. For each String candidate in timeZones, do
// a. If timeZone is an ASCII-case-insensitive match for candidate, return true.
// 3. Return false.
// NOTE: When LibTimeZone is built without ENABLE_TIME_ZONE_DATA, this only recognizes 'UTC',
// which matches the minimum requirements of the Temporal spec.

2
Userland/Libraries/LibJS/Runtime/Temporal/TimeZone.h
View file

@ -36,7 +36,7 @@ private:
Optional<OffsetType> m_offset_nanoseconds; // [[OffsetNanoseconds]]
};
bool is_valid_time_zone_name(String const& time_zone);
bool is_valid_time_zone_name(StringView time_zone);
String canonicalize_time_zone_name(String const& time_zone);
ThrowCompletionOr<TimeZone*> create_temporal_time_zone(VM&, String const& identifier, FunctionObject const* new_target = nullptr);
ISODateTime get_iso_parts_from_epoch(VM&, Crypto::SignedBigInteger const& epoch_nanoseconds);