RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 01:07:36 +00:00
Code Issues Activity Actions

LibJS: Make Heap::allocate<T>() infallible

Browse source 
Stop worrying about tiny OOMs. Work towards #20449.

While going through these, I also changed the function signature in many
places where returning ThrowCompletionOr<T> is no longer necessary.
This commit is contained in:
Andreas Kling 2023-08-13 13:05:26 +02:00
parent 980e7164fe
commit 72c9f56c66
337 changed files with 1229 additions and 1251 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/DOMParsing/InnerHTML.cpp
View file

@ -21,7 +21,7 @@ WebIDL::ExceptionOr<JS::NonnullGCPtr<DOM::DocumentFragment>> parse_fragment(Depr
auto& realm = context_element.realm();
auto new_children = HTML::HTMLParser::parse_html_fragment(context_element, markup);
auto fragment = MUST_OR_THROW_OOM(realm.heap().allocate<DOM::DocumentFragment>(realm, context_element.document()));
auto fragment = realm.heap().allocate<DOM::DocumentFragment>(realm, context_element.document());
for (auto& child : new_children) {
// I don't know if this can throw here, but let's be safe.

2
Userland/Libraries/LibWeb/DOMParsing/XMLSerializer.cpp
View file

@ -25,7 +25,7 @@ namespace Web::DOMParsing {
WebIDL::ExceptionOr<JS::NonnullGCPtr<XMLSerializer>> XMLSerializer::construct_impl(JS::Realm& realm)
{
return MUST_OR_THROW_OOM(realm.heap().allocate<XMLSerializer>(realm, realm));
return realm.heap().allocate<XMLSerializer>(realm, realm);
}
XMLSerializer::XMLSerializer(JS::Realm& realm)