RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 21:37:35 +00:00
Code Issues Activity Actions

IPv4Address: constexpr support

Browse source 
Problem:
- IPv4Address class cannot be used in a compile-time context.
- A union is used by initializing one of the members and reading the
  non-active member. This is undefined behavior and not permitted in a
  `constexpr` context.

Solution:
- Eliminate undefined behavior by changing to a simple `u32` for
  storage instead of the union and performing mask/shift calculations
  for obtaining the individual octets.
- Decorate functions with `constexpr` where possible. Currently string
  formatting and optionals are not `constexpr`-capable so functions
  using those are left out.
- Modify tests to validate functionality in a `constexpr` context in
  addition to the run-time tests already being run. This ensures that
  functionality is the same in both contexts.
This commit is contained in:
Lenny Maiorani 2020-10-28 10:50:53 -06:00 • committed by Andreas Kling
parent 62a74bf282
commit 72d019f4a4
2 changed files with 82 additions and 58 deletions
Download patch file Download diff file Expand all files Collapse all files

50
AK/Tests/TestIPv4Address.cpp
View file

@ -31,31 +31,45 @@
TEST_CASE(should_default_contructor_with_0s)
{
const IPv4Address addr {};
constexpr IPv4Address addr {};
static_assert(addr.is_zero());
EXPECT(addr.is_zero());
}
TEST_CASE(should_construct_from_c_array)
{
const u8 a[4] = { 1, 2, 3, 4 };
const IPv4Address addr(a);
constexpr auto addr = [] {
const u8 a[4] = { 1, 2, 3, 4 };
return IPv4Address(a);
}();
static_assert(!addr.is_zero());
EXPECT(!addr.is_zero());
}
TEST_CASE(should_construct_from_u32)
{
const NetworkOrdered<u32> a = 0x11'22'33'44;
const IPv4Address addr(a);
constexpr auto addr = [] {
const NetworkOrdered<u32> a = 0x11'22'33'44;
return IPv4Address(a);
}();
static_assert(!addr.is_zero());
EXPECT(!addr.is_zero());
}
TEST_CASE(should_get_octets_by_byte_offset)
{
const u8 a[4] = { 1, 25, 39, 42 };
const IPv4Address addr(a);
constexpr IPv4Address addr(1, 25, 39, 42);
static_assert(1 == addr[0]);
static_assert(25 == addr[1]);
static_assert(39 == addr[2]);
static_assert(42 == addr[3]);
EXPECT_EQ(1, addr[0]);
EXPECT_EQ(25, addr[1]);
@ -65,8 +79,7 @@ TEST_CASE(should_get_octets_by_byte_offset)
TEST_CASE(should_convert_to_string)
{
const u8 a[4] = { 1, 25, 39, 42 };
const IPv4Address addr(a);
constexpr IPv4Address addr(1, 25, 39, 42);
EXPECT_EQ("1.25.39.42", addr.to_string());
}
@ -131,26 +144,29 @@ TEST_CASE(should_fill_a_b_d_octets_from_3_parts)
TEST_CASE(should_convert_to_in_addr_t)
{
const u8 a[4] = { 1, 2, 3, 4 };
const IPv4Address addr(a);
constexpr IPv4Address addr(1, 2, 3, 4);
static_assert(0x04'03'02'01u == addr.to_in_addr_t());
EXPECT_EQ(0x04'03'02'01u, addr.to_in_addr_t());
}
TEST_CASE(should_convert_to_u32)
{
const u8 a[4] = { 1, 2, 3, 4 };
const IPv4Address addr(a);
constexpr IPv4Address addr(1, 2, 3, 4);
static_assert(0x04'03'02'01u == addr.to_in_addr_t());
EXPECT_EQ(0x04'03'02'01u, addr.to_u32());
}
TEST_CASE(should_compare)
{
const u8 a[4] = { 1, 2, 3, 4 };
const u8 b[4] = { 1, 2, 3, 5 };
const IPv4Address addr_a(a);
const IPv4Address addr_b(b);
constexpr IPv4Address addr_a(1, 2, 3, 4);
constexpr IPv4Address addr_b(1, 2, 3, 5);
static_assert(addr_a != addr_b);
static_assert(addr_a == addr_a);
EXPECT(addr_a != addr_b);
EXPECT(addr_a == addr_a);