mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 22:57:44 +00:00
LibJS: Add ECMA-262 section/title/URL comments almost everywhere
As mentioned on Discord earlier, we'll add these to all new functions going forward - this is the backfill. Reasons: - It makes you look at the spec, implementing based on MDN or V8 behavior is a no-go - It makes finding the various functions that are non-compliant easier, in the future everything should either have such a comment or, if it's not from the spec at all, a comment explaining why that is the case - It makes it easier to check whether a certain abstract operation is implemented in LibJS, not all of them use the same name as the spec. E.g. RejectPromise() is Promise::reject() - It makes it easier to reason about vm.arguments(), e.g. when the function has a rest parameter - It makes it easier to see whether a certain function is from a proposal or Annex B Also: - Add arguments to all functions and abstract operations that already had a comment - Fix some outdated section numbers - Replace some ecma-international.org URLs with tc39.es
This commit is contained in:
parent
322c8a3995
commit
7327a28ccc
52 changed files with 480 additions and 101 deletions
|
@ -12,9 +12,10 @@
|
|||
|
||||
namespace JS {
|
||||
|
||||
// 10.4.2.2 ArrayCreate, https://tc39.es/ecma262/#sec-arraycreate
|
||||
// 10.4.2.2 ArrayCreate ( length [ , proto ] ), https://tc39.es/ecma262/#sec-arraycreate
|
||||
Array* Array::create(GlobalObject& global_object, size_t length)
|
||||
{
|
||||
// FIXME: Support proto parameter
|
||||
if (length > NumericLimits<u32>::max()) {
|
||||
auto& vm = global_object.vm();
|
||||
vm.throw_exception<RangeError>(global_object, ErrorType::InvalidLength, "array");
|
||||
|
@ -25,12 +26,12 @@ Array* Array::create(GlobalObject& global_object, size_t length)
|
|||
return array;
|
||||
}
|
||||
|
||||
// 7.3.17 CreateArrayFromList, https://tc39.es/ecma262/#sec-createarrayfromlist
|
||||
Array* Array::create_from(GlobalObject& global_object, const Vector<Value>& values)
|
||||
// 7.3.17 CreateArrayFromList ( elements ), https://tc39.es/ecma262/#sec-createarrayfromlist
|
||||
Array* Array::create_from(GlobalObject& global_object, const Vector<Value>& elements)
|
||||
{
|
||||
auto* array = Array::create(global_object);
|
||||
for (size_t i = 0; i < values.size(); ++i)
|
||||
array->define_property(i, values[i]);
|
||||
for (size_t i = 0; i < elements.size(); ++i)
|
||||
array->define_property(i, elements[i]);
|
||||
return array;
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue