mirror of
https://github.com/RGBCube/serenity
synced 2025-07-26 01:37:35 +00:00
LibJS: Add ECMA-262 section/title/URL comments almost everywhere
As mentioned on Discord earlier, we'll add these to all new functions going forward - this is the backfill. Reasons: - It makes you look at the spec, implementing based on MDN or V8 behavior is a no-go - It makes finding the various functions that are non-compliant easier, in the future everything should either have such a comment or, if it's not from the spec at all, a comment explaining why that is the case - It makes it easier to check whether a certain abstract operation is implemented in LibJS, not all of them use the same name as the spec. E.g. RejectPromise() is Promise::reject() - It makes it easier to reason about vm.arguments(), e.g. when the function has a rest parameter - It makes it easier to see whether a certain function is from a proposal or Annex B Also: - Add arguments to all functions and abstract operations that already had a comment - Fix some outdated section numbers - Replace some ecma-international.org URLs with tc39.es
This commit is contained in:
parent
322c8a3995
commit
7327a28ccc
52 changed files with 480 additions and 101 deletions
|
@ -31,14 +31,18 @@ void NumberConstructor::initialize(GlobalObject& global_object)
|
|||
{
|
||||
auto& vm = this->vm();
|
||||
NativeFunction::initialize(global_object);
|
||||
|
||||
// 21.1.2.15 Number.prototype, https://tc39.es/ecma262/#sec-number.prototype
|
||||
define_property(vm.names.prototype, global_object.number_prototype(), 0);
|
||||
|
||||
define_property(vm.names.length, Value(1), Attribute::Configurable);
|
||||
|
||||
u8 attr = Attribute::Writable | Attribute::Configurable;
|
||||
define_native_function(vm.names.isFinite, is_finite, 1, attr);
|
||||
define_native_function(vm.names.isInteger, is_integer, 1, attr);
|
||||
define_native_function(vm.names.isNaN, is_nan, 1, attr);
|
||||
define_native_function(vm.names.isSafeInteger, is_safe_integer, 1, attr);
|
||||
define_property(vm.names.parseFloat, global_object.get(vm.names.parseFloat));
|
||||
define_property(vm.names.prototype, global_object.number_prototype(), 0);
|
||||
define_property(vm.names.length, Value(1), Attribute::Configurable);
|
||||
define_property(vm.names.EPSILON, Value(EPSILON_VALUE), 0);
|
||||
define_property(vm.names.MAX_VALUE, Value(NumericLimits<double>::max()), 0);
|
||||
define_property(vm.names.MIN_VALUE, Value(NumericLimits<double>::min()), 0);
|
||||
|
@ -53,6 +57,7 @@ NumberConstructor::~NumberConstructor()
|
|||
{
|
||||
}
|
||||
|
||||
// 21.1.1.1 Number ( value ), https://tc39.es/ecma262/#sec-number-constructor-number-value
|
||||
Value NumberConstructor::call()
|
||||
{
|
||||
if (!vm().argument_count())
|
||||
|
@ -60,6 +65,7 @@ Value NumberConstructor::call()
|
|||
return vm().argument(0).to_number(global_object());
|
||||
}
|
||||
|
||||
// 21.1.1.1 Number ( value ), https://tc39.es/ecma262/#sec-number-constructor-number-value
|
||||
Value NumberConstructor::construct(Function&)
|
||||
{
|
||||
double number = 0;
|
||||
|
@ -71,21 +77,25 @@ Value NumberConstructor::construct(Function&)
|
|||
return NumberObject::create(global_object(), number);
|
||||
}
|
||||
|
||||
// 21.1.2.2 Number.isFinite ( number ), https://tc39.es/ecma262/#sec-number.isfinite
|
||||
JS_DEFINE_NATIVE_FUNCTION(NumberConstructor::is_finite)
|
||||
{
|
||||
return Value(vm.argument(0).is_finite_number());
|
||||
}
|
||||
|
||||
// 21.1.2.3 Number.isInteger ( number ), https://tc39.es/ecma262/#sec-number.isinteger
|
||||
JS_DEFINE_NATIVE_FUNCTION(NumberConstructor::is_integer)
|
||||
{
|
||||
return Value(vm.argument(0).is_integer());
|
||||
}
|
||||
|
||||
// 21.1.2.4 Number.isNaN ( number ), https://tc39.es/ecma262/#sec-number.isnan
|
||||
JS_DEFINE_NATIVE_FUNCTION(NumberConstructor::is_nan)
|
||||
{
|
||||
return Value(vm.argument(0).is_nan());
|
||||
}
|
||||
|
||||
// 21.1.2.5 Number.isSafeInteger ( number ), https://tc39.es/ecma262/#sec-number.issafeinteger
|
||||
JS_DEFINE_NATIVE_FUNCTION(NumberConstructor::is_safe_integer)
|
||||
{
|
||||
if (!vm.argument(0).is_number())
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue